It is surprisingly poor written to me. This are some of the thing that has to be changed:
- input tag is self closing - options.html
- When using jQuery you should not use document.getElementById, innerHTML - notification.html
- function pausecomp(millis) seems like "busy waiting" - background.html
- html tags interpreted ( wow )
Edit:
It is more of a must than can, actually w3. Inputs must be self closing unlike in the file options.html, where all of them are like:
<input>...</input>
When jQuery is used there is no reason to continue with the usage of:
document.getElementById
- jQuery provides selector - $('#...')innerHTML
- jQuery provides method - $().html()
agreed.
If a question from Stackoverflow, for example like this, contains html tag with <>, the tag is interpreted. So you will receive this question with an actual input. Maybe I should write something there, like sanitize - http://xkcd.com/327/.
Something new to fix:
- Using both
new Array
and[]
is sign of bad style. You should chose one, and as Crocford and SO community strongly suggest it should be[]
Update:
- code style - a good practice is to use curly brackets, even if they are not needed now. This will produce a code which will be easier to update(options.html):
Use
if (condition)
{
// code ...
}else{
// code ...
}
instead of
if (condition)
// code ...
else
// code ...
- Another optimization - for cycle, from MDN(notification.html)