/questions returns wrong markdown when a suggested edit is improved

Question

The /questions API method returns wrong markdown when the last revisions were made by a suggested edit improved in the review queue. This event leads to two revisions (one for the suggested edit and one for the final version) and the first one is used for the markdown and the second one for the rendered post body.

Consider this Bricks question.
The last edit was made during a Suggested Edits review, where the reviewer removed the direct imgur link between the asterisks.
The /questions API method returns the current version of the question (revision 5) in the body field, but the markdown of the suggested edit (revision 4) in the body_markdown field.

Live demo:

Another example is this Meta Stack Exchange question, though it could be edited again by the time you see it. Live demo:

Answer 1

This was an old, old bug: a bit of logic assumes that revisions can be ordered by their creation date. This is not true for Improved edits, as both the suggested edit and subsequent Improvement share the same date... So you'd get the wrong markdown.

I've resolved this by falling back on ID to order, which is how we do it most other places. This may not always work reliably in the case of edit collisions however (two independent revisions being submitted simultaneously) - but, the results of such things tend to be unpredictable anyway.